search

GoogleCloudPlatform / cloud-run-button

Let anyone deploy your GitHub repos to Google Cloud Run with a single click
https://cloud.run
Apache License 2.0
527 stars 92 forks source link

Add support for "buildpacks" field in app.json #3

Open ahmetb opened 5 years ago

ahmetb commented 5 years ago

@jamesward I feel like we should just assume --builder=heroku/buildpacks, and then have an optional array for --buildpack, so we call the CLI like:

pack build --builder=heroku/buildpacks [--buildpack=foo --buildpack=bar ...]

wdyt?

jamesward commented 5 years ago

Sounds great to me but we do need to push to get a Cloud Run bug fixed where most buildpack built images do not currently work (Node & Python are currently broken).

ahmetb commented 5 years ago

Yes learned it the hard way yesterday. The whole project does not seem stable or ready for prime-time. I won’t be touching this anytime soon.

jamesward commented 5 years ago

It’s actually a bug in Cloud Run, because the containers work fine in docket.

jamesward commented 4 years ago

There is a way to specify specific buildpacks via a project.toml file in the root: https://github.com/buildpacks/pack/pull/421