search

GoogleCloudPlatform / cloud-run-button

Let anyone deploy your GitHub repos to Google Cloud Run with a single click
https://cloud.run
Apache License 2.0
526 stars 91 forks source link

Use pack CLI in Cloud Shell #93

Closed chanseokoh closed 4 years ago

chanseokoh commented 4 years ago

Cloud Shell will soon ship the most recent pack CLI (v0.4.1) for Buildpacks. There have been many changes to the Buildpacks spec; hopefully nothing breaks.

Also, the binary will be placed under /usr/local/bin/pack where the current Dockerfile tries to create a symlink. The symlink command will probably break by then.

jamesward commented 4 years ago

See #87

jamesward commented 4 years ago

What is the thing about the symlink? Can you provide more details?

chanseokoh commented 4 years ago

This line: https://github.com/GoogleCloudPlatform/cloud-run-button/blob/e2c4fa243a2c76142f654ca2eec6a31f84fe3610/Dockerfile#L19

When /usr/local/bin/pack is provided in the Cloud Shell base image, I think the command will fail. Basically what I am saying is if pack becomes available, we should update the Dockerfile.

jamesward commented 4 years ago

Oh, have you heard that they are talking about adding pack to the base image?

chanseokoh commented 4 years ago

Yeah, see the internal bug 141612258. They just need to rebuild and roll out the new Cloud Shell image.

jamesward commented 4 years ago

Oh! Thanks for the heads up. At that point we can just drop our inclusion of pack from here.

ahmetb commented 4 years ago

Especially helpful since we have no build failure alerting from GCB.

chanseokoh commented 4 years ago

It went live. /usr/local/bin/pack is now included in Cloud Shell by default.