Revert: asset path - Githubissues

GoogleCloudPlatform / cloud-run-hello

Demo container for Google Cloud Run

https://cloud.run

Apache License 2.0

99 stars 144 forks source link

Revert: asset path #100

Open Deleplace opened 3 months ago

Deleplace commented 3 months ago

Fixes #98

Revert "read index.html using absolute path (#96)"
Revert "read assets/ using absolute path (#97)"

I could confirm this code (after revert) works correctly:

locally

% go run .

in Docker:

docker build -t cloud-run-hello-fix98 .
docker run -ePORT=8080 -p8080:8080 cloud-run-hello-fix98

Deleplace commented 3 months ago

See also #99, which would avoid this ambiguity altogether

jihuin commented 3 months ago

Hi Valentin, thanks for catching this. The purpose of PR #96 and #97 was to fix the broken deployment of the placeholder image to Cloud Run with automatic base image update (private preview feature).

Created PR #102 to cover all use cases.

grayside commented 1 month ago

It looks like this PR's change was reimplemented and merged in #102. Are we good to close this one?