search

GoogleCloudPlatform / cloud-run-hello

Demo container for Google Cloud Run
https://cloud.run
Apache License 2.0
99 stars 144 forks source link

The $PORT in the log message is a literal #90

Closed ferrarimarco closed 1 month ago

ferrarimarco commented 6 months ago

Hi folks!

When deploying this service on Cloud Run, the $PORT is printed as a literal in the log:

2024/04/17 14:13:36 Hello from Cloud Run! The container started successfully and is listening for HTTP requests on $PORT

Shall this be formatted?

https://github.com/GoogleCloudPlatform/cloud-run-hello/blob/7e45d10641efba44275ceed0c0aff2cc60a2866c/hello.go#L188

Thanks for your support!

JulienBreux commented 3 months ago

Hi @ferrarimarco,

Thanks for contributing.

Fix in progress.

Have a nice day :)

ferrarimarco commented 3 months ago

Thanks @JulienBreux !