main: Default min requests to 0

GoogleCloudPlatform / cloud-run-release-manager

[EXPERIMENTAL] Automated canary rollout tool for Cloud Run services.

Apache License 2.0

128 stars 10 forks source link

main: Default min requests to 0 #103

Closed gvso closed 4 years ago

gvso commented 4 years ago

The previous value of 100 is an issue since it requires that the service gets a lot of requests, especially at the beginning of the rollout, to determine the candidate's health

ahmetb commented 4 years ago

I think the goal was to add the defaults explicitly to deployment command?

gvso commented 4 years ago

Yes. I went ahead and just pass the same values as the default ones, so the experience in CLI is the same as the deployed one by default. Any thoughts on that?