GoogleCloudPlatform / cloud-sql-nodejs-connector

A JavaScript library for connecting securely to your Cloud SQL instances
Apache License 2.0
67 stars 8 forks source link

Improve caching of Instance configs #304

Open jackwotherspoon opened 7 months ago

jackwotherspoon commented 7 months ago

Currently we cache instance connection info by instanceConnectionName and error out if the iam authn flag switches between consecutive connect calls. We should update the hash key (instanceConnectionName+iam authn) for how we cache our configs so that we can handle support for flag switches without needing to error.

https://github.com/GoogleCloudPlatform/cloud-sql-nodejs-connector/blob/00a6eae6a18aed0cd1e62d31d46e61eb0c13c7e8/src/connector.ts#L76-L79