Allow UTF-8 letters in username, fixes #24

GoogleCloudPlatform / cloudbowl-microservice-game

Apache License 2.0

46 stars 100 forks source link

Allow UTF-8 letters in username, fixes #24 #28

Closed tarczynskitomek closed 2 years ago

tarczynskitomek commented 2 years ago

changed the regex used in username validation to allow letters from any language/alphabet, still disallowing non-letter characters.
test cases use three pangrams from Polish, Czech and Greek

jamesward commented 2 years ago

Thank you! For some reason the CLA boot is still unhappy. Can you check that again?

tarczynskitomek commented 2 years ago

Thank you! For some reason the CLA boot is still unhappy. Can you check that again?

Fixed, I've used my private email when signing the CLA, but committed the change using work email, hence the check being unhappy. :-)

jamesward commented 2 years ago

Thank you! This should get rolled out in about 15 minutes. Then we can test it on the prod site.

tarczynskitomek commented 2 years ago

Cool, I'm happy to help :-) Anything I can help out testing?

jamesward commented 2 years ago

Can you try: https://cloudbowl.gcplab.me/snowball-k8s/join

tarczynskitomek commented 2 years ago

Can you try: https://cloudbowl.gcplab.me/snowball-k8s/join

Name verification passes, but I can't join the arena. If I use the same URL that I've used during the hackaton (https://34.120.168.101.sslip.io), I get an error "Player with that hostname already exists in the arena". If I bump the IP in the URL to 34.120.168.102 I get an error page with an exception ID 7m36nkhc7, I guess this is due to the service URL not being resolved correctly.

jamesward commented 2 years ago

I deleted your player so you should be able to join again. Also filed an issue for the unhandled error.

tarczynskitomek commented 2 years ago

Now I get the same error page when entering random IP. Form validation passes, but there's an issue later on. This happens now matter if I use ń or n in my surname.

I've checked https://cloudbowl.gcplab.me/snowball-k8s and it appears that all player services are reported to return error, maybe there is some issue further down the process?

jamesward commented 2 years ago

Oh, the underlying projects for these services were deleted so the validation will fail. Mind trying one more time with this service url: https://cloudbowl-samples-java-springboot-zymdgdhl5a-uc.a.run.app

tarczynskitomek commented 2 years ago

This time worked like a charm, thanks! :-)

jamesward commented 2 years ago

Awesome! Thanks a ton for helping fix my silly mistake.

tarczynskitomek commented 2 years ago

Happy to help ;-)