GoogleCloudPlatform / cloudml-samples

Cloud ML Engine repo. Please visit the new Vertex AI samples repo at https://github.com/GoogleCloudPlatform/vertex-ai-samples
https://cloud.google.com/ai-platform/docs/
Apache License 2.0
1.52k stars 859 forks source link

Update census/tf-keras save_keras_model output #453

Closed liufuyang closed 5 years ago

liufuyang commented 5 years ago

Otherwise I have error when running locally:

I0827 10:10:30.505312 4518344128 builder_impl.py:421] SavedModel written to: local-training-output/keras_export/saved_model.pb
Traceback (most recent call last):
  File "/usr/local/Cellar/python/3.7.3/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/local/Cellar/python/3.7.3/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/Users/fuyangl/cloudml-samples/census/tf-keras/trainer/task.py", line 130, in <module>
    train_and_evaluate(args)
  File "/Users/fuyangl/cloudml-samples/census/tf-keras/trainer/task.py", line 123, in train_and_evaluate
    export_path = export_path.decode('utf-8')
AttributeError: 'NoneType' object has no attribute 'decode'

This change is Reviewable

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

liufuyang commented 5 years ago

@googlebot I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

gogasca commented 5 years ago

LGTM, thanks for your contribution