search

GoogleCloudPlatform / cloudml-samples

Cloud ML Engine repo. Please visit the new Vertex AI samples repo at https://github.com/GoogleCloudPlatform/vertex-ai-samples
https://cloud.google.com/ai-platform/docs/
Apache License 2.0
1.52k stars 859 forks source link

Update Text Classification with PyTorch and CMLE #456

Closed ksalama closed 4 years ago

ksalama commented 4 years ago

This fixes issue 410

This change is Reviewable

review-notebook-app[bot] commented 4 years ago

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

thedriftofwords commented 4 years ago

The machine type name is incorrect. (See my comment in issue 410) Also, does this work in Python 3?

ksalama commented 4 years ago

@thedriftofwords - I have applied the fixes suggested by Henry, and it seems it works fine now

nnegrey commented 4 years ago

I still get an error: 

Creating version (this might take a few minutes)......failed.                  
ERROR: (gcloud.beta.ai-platform.versions.create) Create Version failed. Bad model detected with error:  "Failed to load model: Unexpected error when loading the model: unsupported pickle protocol: 3 (Error code: 0)"
nnegrey commented 4 years ago

Fixed versioning then got:

Creating version (this might take a few minutes)......failed.                  
ERROR: (gcloud.beta.ai-platform.versions.create) Create Version failed. Bad model detected with error:  "Failed to load model: Unexpected error when loading the model: problem in model_prediction - <type 'exceptions.ImportError'>: No module named _C (Error code: 0)"
andrewferlitsch commented 4 years ago

@nnegrey Any idea of the cause of error?

ksalama commented 4 years ago

I tested the notebook and it seems to be working fine. Couldn't reproduce the error.

gogasca commented 4 years ago

Closing as notebook was updated with changes