On Windows 2016, script must explicitly select TLS 1.2

GoogleCloudPlatform / compute-gpu-installation

Apache License 2.0

77 stars 35 forks source link

On Windows 2016, script must explicitly select TLS 1.2 #21

Closed tpdownes closed 1 year ago

tpdownes commented 1 year ago

Describe the bug The cloud.google.com instructions advise a two-step process for downloading and executing the script contained in this repo. I find that, on Windows 2016, the 1st step to download the script fails unless one previously sets TLS1.2:

[Net.ServicePointManager]::SecurityProtocol = 'Tls12'

Environment

Operating system: What OS are you running, would be best to point at specific disk image on GCP you are using if it's public.

Windows 2016 family (latest)

Graphics card: What kind of GPU are you trying to use. How many devices do you have attached?

n1-standard-8 with 1 T4

m-strzelczyk commented 1 year ago

@tpdownes So the right way to download the script onto the machine is:

[Net.ServicePointManager]::SecurityProtocol = 'Tls12'
Invoke-WebRequest https://github.com/GoogleCloudPlatform/compute-gpu-installation/raw/main/windows/install_gpu_driver.ps1 -OutFile C:\install_gpu_driver.ps1

Right?

Windows 2016 seems to be out of it's mainstream support. But it's a small change, so we might suggest to add it to the documentation page and our README.

tpdownes commented 1 year ago

Yes. The latest windows-2016 images on GCP are from May 2023 so I think it remains relevant.

Minimum action seems to be a small update to windows/README.md.

I'm not sure if it affects Windows 2019. If it affects Windows 2019, I might consider escalating it to the OS image team to configure a global default that is consistent with reality on the internet. TLS 1.1 and below have been deprecated for a couple years.

tpdownes commented 1 year ago

For clarity, I believe that if one adds a 3rd line to run the script, then it inherits the TLS 1.2 setting. If it does not, I will say so explicitly here.

[Net.ServicePointManager]::SecurityProtocol = 'Tls12'
Invoke-WebRequest https://github.com/GoogleCloudPlatform/compute-gpu-installation/raw/main/windows/install_gpu_driver.ps1 -OutFile C:\install_gpu_driver.ps1
C:\install_gpu_driver.ps1

m-strzelczyk commented 1 year ago

I have submitted a CL to the Cloud Docs. Inside the script #23 is taking care of setting TLS config for Windows 2016.

Waiting for the Docs page to update and will close this then :)

m-strzelczyk commented 1 year ago

The CL is submitted. It will soon be published.