search

GoogleCloudPlatform / compute-image-packages

Packages for Google Compute Engine Linux images.
https://cloud.google.com/compute/docs/images
Apache License 2.0
372 stars 213 forks source link

fix bugs in disk-expand #879

Closed hopkiw closed 4 years ago

hopkiw commented 4 years ago
codecov[bot] commented 4 years ago

Codecov Report

Merging #879 into development will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #879   +/-   ##
============================================
  Coverage        97.37%   97.37%           
============================================
  Files               58       58           
  Lines             4801     4801           
  Branches           246      246           
============================================
  Hits              4675     4675           
  Misses             108      108           
  Partials            18       18

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eff97a7...53a547f. Read the comment docs.

google-oss-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hopkiw, zmarano To complete the pull request process, please assign You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/compute-image-packages/blob/development/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hopkiw commented 4 years ago

/packagebuild

hopkiw commented 4 years ago

working on: debian-10 (gpt) centos-7,rhel-7 (gpt, msdos) centos-8,rhel-8 (gpt, msdos)

created 10g instance, installed package, resized disk to 30g, rebooted, confirmed 30g this needs a test specifically to check that the condition where root is not the last partition does not get resized.

hopkiw commented 4 years ago

/hold (needs packagebuild post-submit before merging)

hopkiw commented 4 years ago

blocking on GoogleCloudPlatform/oss-test-infra#330