Add ARM support for COS preloading

GoogleCloudPlatform / compute-image-tools

Tools and scripts for Google Compute Engine images.

https://cloud.google.com/compute/docs/images

Apache License 2.0

200 stars 145 forks source link

Add ARM support for COS preloading #2333

Closed sejalsharma-google closed 3 months ago

sejalsharma-google commented 3 months ago

This PR adds ARM support for COS preloading:

Adds worker_machine and machine_type as args to the install_package_cos.wf.json: allows us to specify ARM specific machine types i.e. debian-11-worker-arm64, t2a-standard-1
Moves compiling the debian package (compile_debian_package.sh) out of the cloudbuild and in the worker machine. This is because for ARM image, debian packaging should be compiled in an ARM env and cloudbuild does not support ARM.
Delete's instance_config file in worker machine to pass all debian tests.

CCing @a-crate, @dorileo, and @zmarano.

google-oss-prow[bot] commented 3 months ago

Hi @sejalsharma-google. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

a-crate commented 3 months ago

We need to set the new variables in concourse right? The ones that don't have a default anymore?

/ok-to-test /lgtm

sejalsharma-google commented 3 months ago

We need to set the new variables in concourse right? The ones that don't have a default anymore?

Yes, we would have to pass them in. I haven't made that PR yet since COS is disabled on Concourse right now. When we can re-enable it, I'll re-write the calls

a-crate commented 3 months ago

/approve

google-oss-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-crate, sejalsharma-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/compute-image-tools/blob/master/OWNERS)~~ [a-crate] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment