Closed jmcgeheeiv closed 5 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
ℹ️ Googlers: Go here for more info.
I signed.
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.
ℹ️ Googlers: Go here for more info.
Closing in favor of #12.
The playbook had drifted away from the text of
README.md
, so I corrected what I could.I eliminated literal user name.
I modified the instructions so the
credentials_file
name is constant.I modified the instructions so that the current value of
project
ingce_vars/auth
need not beYOUR_PROJECT_ID
. This is because it is too easy to forget to change this value from an actual project ID toYOUR_PROJECT_ID
before committing.Replaced deprecated
include
withimport_playbook
.There is no file
clean-up.yml
, so I corrected it tocleanup.yml
. Although I did not say so inREADME.md
,cleanup.yml
is quite broken.