GoogleCloudPlatform / compute-video-demo-ansible

Supporting details for the Using Ansible on Compute Engine video demo
http://googlecloudplatform.github.io/compute-video-demo-ansible/
Apache License 2.0
123 stars 68 forks source link

Correct, modernize and make more independent of the user #10

Closed jmcgeheeiv closed 5 years ago

jmcgeheeiv commented 5 years ago

The playbook had drifted away from the text of README.md, so I corrected what I could.

I eliminated literal user name.

I modified the instructions so the credentials_file name is constant.

I modified the instructions so that the current value of project in gce_vars/auth need not be YOUR_PROJECT_ID. This is because it is too easy to forget to change this value from an actual project ID to YOUR_PROJECT_ID before committing.

Replaced deprecated include with import_playbook.

There is no file clean-up.yml, so I corrected it to cleanup.yml. Although I did not say so in README.md, cleanup.yml is quite broken.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

jmcgeheeiv commented 5 years ago

I signed.

googlebot commented 5 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

jmcgeheeiv commented 5 years ago

Closing in favor of #12.