GoogleCloudPlatform / config-validator

Golang library which provides functionality to evaluate GCP resources against Rego-based policies
Apache License 2.0
45 stars 36 forks source link

Cleaned up test code to remove levels of indirection #178

Closed melinath closed 2 years ago

melinath commented 2 years ago

the match and exclude functions make each test case slightly more compact, but they don't seem to provide significant value beyond that, and they obfuscate the underlying data structure that is being tested. I would prefer to have the test cases be slightly longer but easier to understand at a glance, if that sounds good?

This may be slightly easier to review if you make the diff ignore whitespace changes.