feat: migrate from github protobuf

GoogleCloudPlatform / config-validator

Golang library which provides functionality to evaluate GCP resources against Rego-based policies

Apache License 2.0

45 stars 34 forks source link

feat: migrate from github protobuf #211

Closed apeabody closed 1 year ago

melinath commented 1 year ago

@apeabody could you elaborate on why this change is necessary?

apeabody commented 1 year ago

Hi @melinath

github.com/gogo/protobuf is deprecated
github.com/golang/protobuf is superseded by google.golang.org/protobuf
Preferable for only a single google.golang.org/protobuf module (Fewer indirects when importing, etc)
A few misc updates/formatting changes

If there is a particular aspect of concern, I can separate/back out.

melinath commented 1 year ago

There's not a particular aspect of concern, we've just had some issue with protobufs in this repository being difficult to upgrade and causing unexpected problems later. I think this may be the upgrade we wanted to do previously (but which wasn't possible at the time.)

melinath commented 1 year ago

approving since tests are passing