GoogleCloudPlatform / continuous-deployment-on-kubernetes

Get up and running with Jenkins on Google Kubernetes Engine
Apache License 2.0
1.59k stars 890 forks source link

update Jenkins chart #149

Closed torstenwalter closed 5 years ago

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

torstenwalter commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

viglesiasce commented 5 years ago

@davidstanke can you take a look?

viglesiasce commented 5 years ago

Oh and thank you for the contribution @torstenwalter!!

torstenwalter commented 5 years ago

I rebased it on master. I found this repo while doing a quiklab. So please pay attention that the lab might need an update, too.

BTW: Are you sure you need a PVC with 100GB? For demos a smaller one should be sufficient.

davidstanke commented 5 years ago

FYI, I'm updating the lab content; we'll merge this at the same time as that gets published. Thanks again, @torstenwalter !

viglesiasce commented 5 years ago

Thanks @torstenwalter for the contrib and @davidstanke for the review and updates.