search

GoogleCloudPlatform / data-analytics-golden-demo

An end to end demo of Google's Cloud data and analytic stack.
Apache License 2.0
212 stars 69 forks source link

Hardcoded region and location #47

Closed dinigo closed 1 year ago

dinigo commented 1 year ago

Location and region is hardcoded over and over in the terraform config.

This makes it difficult to extract the location/region to be abale to easily localise the deployment

Location/Region MUST be configurable from the outside

AdamPaternostro commented 1 year ago

Some of this is due to preview features and only being in certain regions. I will have a preview region for these services.

AdamPaternostro commented 1 year ago

This has been corrected: https://github.com/GoogleCloudPlatform/data-analytics-golden-demo/blob/main/terraform/tf-variables.tf#L103-L266

AdamPaternostro commented 1 year ago

Please see this for an EU deployment (this has been tested) https://github.com/GoogleCloudPlatform/data-analytics-golden-demo/blob/main/deploy-europe-region.sh