search

GoogleCloudPlatform / data-science-on-gcp

Source code accompanying book: Data Science on the Google Cloud Platform, Valliappa Lakshmanan, O'Reilly 2017
Apache License 2.0
1.32k stars 712 forks source link

Edition2 Review: Ch04 CRD #134

Closed crdietrich closed 2 years ago

crdietrich commented 2 years ago

Chapter 2 suggested revisions:

  1. Exception handling 'line' to '{field}'
  2. Add pip upgrade and cache purge to 'install_packages.sh' - fixes hung install in cloud shell
  3. add python3 shebang, PEP8 consistent tab indents and return format (falls under issue #133)
  4. Add 'Year:string' to flights_schema, df06.py - couldn't track where this variable was inserted, needed for pipeline to work
lakshmanok commented 2 years ago

thanks, Colin! Could you fix the conflict in df07.py and sign the CLA?

crdietrich commented 2 years ago

Both done!