Ch10 correct? I think this might need to be Ch11?

GoogleCloudPlatform / data-science-on-gcp

Source code accompanying book: Data Science on the Google Cloud Platform, Valliappa Lakshmanan, O'Reilly 2017

Apache License 2.0

1.31k stars 715 forks source link

Ch10 correct? I think this might need to be Ch11? #135

Closed graciofilipe closed 2 years ago

graciofilipe commented 2 years ago

https://github.com/GoogleCloudPlatform/data-science-on-gcp/blob/021464769d4523231d55eccbe8e04d2c0a3c4b56/11_realtime/create_traindata.py#L57

graciofilipe commented 2 years ago

The generated data as is goes to a ch10 folder. but this is ch11. The next step in "train_on_vertex_ai.py" expects to find the values in ch11.

all_files = tf.io.gfile.glob('gs://{}/ch11/data/all*.csv'.format(BUCKET))

lakshmanok commented 2 years ago

I think so ... but the reorg has messed things up ... I obviously have the data both in Ch 10 and 11 ... so if you are doing it from a clean environment and can verify, that will be great.

graciofilipe commented 2 years ago

Relevant PR here: https://github.com/GoogleCloudPlatform/data-science-on-gcp/pull/136/files