GoogleCloudPlatform / data-science-on-gcp

Source code accompanying book: Data Science on the Google Cloud Platform, Valliappa Lakshmanan, O'Reilly 2017
Apache License 2.0
1.31k stars 712 forks source link

ss-jm-add-tf-version-flag #147

Closed joemansfield closed 2 years ago

joemansfield commented 2 years ago

Adding --tfversion flag to allow user to override default TensorFlow version set in the environment.

Required for Qwiklabs lab implementation.

joemansfield commented 2 years ago

@lakshmanok I modified code in the Chapter 10 train-on-vertexai.py as per your suggestion on March 14 in the previous update that added the --cpu_only flag. Can your merge?

lakshmanok commented 2 years ago

Done. Have a great day!

Mylene Biddle

@.***

Training Lab Architect

My working hours may not be your working hours - please do not feel obligated to reply outside of your normal work schedule :)

On Tue, Mar 29, 2022 at 10:34 AM Lakshmanan Valliappa @.***> wrote:

this looks great. However, I no longer have write access to the repo to merge it ...

+Mylene Biddle @.***> could you help?

thanks Lak

On Tue, Mar 29, 2022 at 3:34 AM Joe Mansfield @.***> wrote:

@lakshmanok https://github.com/lakshmanok I modified code in the Chapter 10 train-on-vertexai.py as per your suggestion on March 14 in the previous update that added the --cpu_only flag. Can your merge?

— Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/data-science-on-gcp/pull/147#issuecomment-1081707183, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANJPZ6IMPDL57FDQ7IGTYTVCLMDTANCNFSM5R56KVAA . You are receiving this because you were mentioned.Message ID: @.***>

lakshmanok commented 2 years ago

Thanks!

Lak

On Tue, Mar 29, 2022, 9:38 AM Mylene Biddle @.***> wrote:

Done. Have a great day!

Mylene Biddle

@.***

Training Lab Architect

My working hours may not be your working hours - please do not feel obligated to reply outside of your normal work schedule :)

On Tue, Mar 29, 2022 at 10:34 AM Lakshmanan Valliappa @.***> wrote:

this looks great. However, I no longer have write access to the repo to merge it ...

+Mylene Biddle @.***> could you help?

thanks Lak

On Tue, Mar 29, 2022 at 3:34 AM Joe Mansfield @.***> wrote:

@lakshmanok https://github.com/lakshmanok I modified code in the Chapter 10 train-on-vertexai.py as per your suggestion on March 14 in the previous update that added the --cpu_only flag. Can your merge?

— Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/data-science-on-gcp/pull/147#issuecomment-1081707183, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANJPZ6IMPDL57FDQ7IGTYTVCLMDTANCNFSM5R56KVAA . You are receiving this because you were mentioned.Message ID: @.*** com>

lakshmanok commented 1 year ago

this looks great. However, I no longer have write access to the repo to merge it ...

+Mylene Biddle @.***> could you help?

thanks Lak

On Tue, Mar 29, 2022 at 3:34 AM Joe Mansfield @.***> wrote:

@lakshmanok https://github.com/lakshmanok I modified code in the Chapter 10 train-on-vertexai.py as per your suggestion on March 14 in the previous update that added the --cpu_only flag. Can your merge?

— Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/data-science-on-gcp/pull/147#issuecomment-1081707183, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANJPZ6IMPDL57FDQ7IGTYTVCLMDTANCNFSM5R56KVAA . You are receiving this because you were mentioned.Message ID: @.***>