GoogleCloudPlatform / data-science-on-gcp

Source code accompanying book: Data Science on the Google Cloud Platform, Valliappa Lakshmanan, O'Reilly 2017
Apache License 2.0
1.31k stars 715 forks source link

Added dependency for 04_streaming exercises. #44

Closed bdabrowski closed 5 years ago

bdabrowski commented 5 years ago

In PR added missing dependency for the exercises.

Though it doesn't appear to work properly for --upgrade flag as it seem to complain about version conflict so was made as separate line.

Related issue: https://github.com/GoogleCloudPlatform/data-science-on-gcp/issues/34 Suggested answer from #34 doesn't seem to work or require more investigation.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
bdabrowski commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

lakshmanok commented 5 years ago

The fix is really to have only apache-beam[gcp] Will close this issue and apply the right fix