ER: Hardened Docker Build.

GoogleCloudPlatform / database-assessment

Database Migration Assessment

https://googlecloudplatform.github.io/database-assessment/

Apache License 2.0

61 stars 35 forks source link

ER: Hardened Docker Build. #166

Closed cofin closed 2 years ago

cofin commented 2 years ago

This PR has a number of changes:

Config is now a Python dataclass
Gunicorn is now installed with api-requirements. Flask executes through Gunicorn in the container.
Mutli-staged docker build. Runtime environment has limited packages and no build packages (reduced attack surface)
Code is namespaced under db_assessment module.
Removed unused imports and sorted imports
Spelling corrections

a200462790 commented 2 years ago

/gcbrun

a200462790 commented 2 years ago

/gcbrun

a200462790 commented 2 years ago

/gcbrun

a200462790 commented 2 years ago

/gcbrun

cofin commented 2 years ago

After the latest round of edits, I have been able to execute this locally as well as submit a manual Cloud Run build. Removing the draft status on the PR.

cofin commented 2 years ago

/gcbrun

a200462790 commented 2 years ago

LGTM