GoogleCloudPlatform / database-assessment

Database Migration Assessment
https://googlecloudplatform.github.io/database-assessment/
Apache License 2.0
56 stars 34 forks source link

BUG: Derived parameter DMASourceID is not populated #348

Closed mcastanhogit closed 4 months ago

mcastanhogit commented 5 months ago

Description

Execution script assessment for MSSQL occur "Derived parameter DMASourceID is not populated" because in the file "instanceReview.ps1" needs a space in line 127 on parameter "-h-1-w 32768" $dmaSourceIdObj = @(sqlcmd -S $serverName -i sql\getDmaSourceId.sql -U $collectionUserName -P $collectionUserPass -C -l 30 -W -m 1 -u -h-1-w 32768)

Version

None

Priority

priority:0

What oracle database version are you seeing the problem on?

None

Which sql script version ?

None

Relevant log output

PS C:\Users\admin\dma\db>
PS C:\Users\admin\dma\db> powershell.exe .\RunAssessment.bat -serverName winsqls -port 1433 -collectionUserName sa -collectionUserPass dmasauser123 -manualUniId mcastanho
[02/07/24 17:53:54]   Retrieving Metadata Information from winsqls,1433
Sqlcmd: '32768': Unexpected argument. Enter '-?' for help.
[02/07/24 17:53:55]   Creating directory C:\Users\admin\dma\db\opdb_mssql_PerfCounter__16041001_4.3.28_MCASTANHO_master_MSSQLSERVER_020724175354

[02/07/24 17:53:55]   Checking directory path + log file name lengths for max length limitations...
[02/07/24 17:53:55]   Derived parameter DMASourceID is not populated.  Defaulting value....
[02/07/24 17:53:55]
[02/07/24 17:53:55]   Checking directory path + output file name lengths for max length limitations...
[02/07/24 17:53:55]   Executing Assessment on Server winsqls,1433 Against the Following Databases:
shane-borden commented 4 months ago

Thank you for reporting this. This is occuring in situations where the instance is running on the non-default port and the user specifies a port on the command line.

In your case since your instance is running on the default port, you should be able to omit that switch and obtain a successful run.

I will incorporate the fix into the next release. Thank you for reporting this.