search

GoogleCloudPlatform / datacatalog-connectors-bi

Sample code with integration between Data Catalog and BI data sources.
Apache License 2.0
32 stars 16 forks source link

Add a dependency finders class hierarchy #101

Closed ricardolsmendes closed 3 years ago

ricardolsmendes commented 3 years ago

- What I did Added a dependency finders class hierarchy.

- How I did it

  1. Created the addons.LinkedResourceBasedFinder and addons.TagBasedFinder classes that inherit from addons.ElastiCubeDependencyFinder. The intent is to separate different find capabilities in specific classes, improving the overall code readability.
  2. Refactored the impacted unit tests as well.

- How to verify it Run the unit tests and, if possible, the Sisense connector in an integrated environment.

- Description for the changelog Added a dependency finders class hierarchy.

PS: This PR is a sequel of https://github.com/GoogleCloudPlatform/datacatalog-connectors-bi/pull/100 and part of the effort to deliver #70.