search

GoogleCloudPlatform / datacatalog-connectors-bi

Sample code with integration between Data Catalog and BI data sources.
Apache License 2.0
32 stars 16 forks source link

Set the order of the Tag Template fields #68

Closed ricardolsmendes closed 3 years ago

ricardolsmendes commented 3 years ago

- What I did Set the order of the Tag Template fields, so their related Tag fields will always be displayed in the same order in the Data Catalog UI.

- How I did it By specifying a value for the order attribute of all Tag Template fields.

- How to verify it Run the connector in an integrated environment. Then, verify the order of the Tags fields to make sure they are presented in the same order they were added to their respective Tag Templates.

- Description for the changelog Set the order of the Tag Template fields

ricardolsmendes commented 3 years ago

Just a question, what happens if the user had executed the Qlik connector before this change? Does it work smoothly or does the user need to delete the tag templates and re run it?

If the user has to delete the templates, I'd add this to Qlik docs, and state that it's a breaking change.

It works smoothly with preexisting Tag Templates. The only difference is that fields belonging to Tags created from old Templates will not be presented in the specified order. Users may also use the datacatalog-connectors-bi/google-datacatalog-qlik-connector/tools/scripts/cleanup_datacatalog.py script in order to delete the existing Tag Templates; they will be recreated in the next connection execution.

mesmacosta commented 3 years ago

LGTM!