search

GoogleCloudPlatform / datacatalog-connectors-bi

Sample code with integration between Data Catalog and BI data sources.
Apache License 2.0
32 stars 16 forks source link

Scrape Sisense Dashboards metadata #80

Closed ricardolsmendes closed 3 years ago

ricardolsmendes commented 3 years ago

- What I did

  1. Added support for Sisense Dashboards metadata scraping.
  2. I've also changed the REST API results pagination/deduping logic because I found a minor bug while working on the present feature (in a nutshell: tuple() does not work seamlessly with dicts that contain complex values such as lists). I realized that pagination is not supported by GET /dashboards yet, but it was a bit late, so I decided to keep the fix to avoid trouble with the coming objects to be scraped.

- How I did it The main change comprises 3 new methods and their unit tests:

  1. MetadataScraper.scrape_all_dashboards()
  2. RESTAPIHelper.get_all_dashboards()
  3. RESTAPIHelper.get_dashboard()

- How to verify it Run the unit tests.

- Description for the changelog Added support for Sisense Dashboards metadata scraping.

PS: This PR is part of the effort to deliver feature #70.