GoogleCloudPlatform / datacatalog-connectors-bi

Sample code with integration between Data Catalog and BI data sources.
Apache License 2.0
32 stars 16 forks source link

Find ElastiCube dependencies #98

Closed ricardolsmendes closed 3 years ago

ricardolsmendes commented 3 years ago

- What I did Added the addons.ElastiCubeDependencyFinder class, the core of a new feature for the Sisense Connector CLI that is going to allow users to easily find and display the specific fields and filters that depend on a given ElastiCube data source, table, and/or column.

- How I did it Added the addons.ElastiCubeDependencyFinder class and its unit tests as well.

- How to verify it Run the unit tests.

- Description for the changelog Added the addons.ElastiCubeDependencyFinder class.

PS 1: This PR is part of the effort to deliver #70. PS 2: The CLI changes and related docs are already done but will be tackled in a separate PR to make the code review easier.

ricardolsmendes commented 3 years ago

Hey @mesmacosta, although you have already approved the PR, I'll kindly ask you to have a look at the table and column named args before merging it. Please let me know if the current approach makes sense to you. Thanks!