GoogleCloudPlatform / dataflow-opinion-analysis

Opinion Analysis of News, Threaded Conversations, and User Generated Content
Apache License 2.0
101 stars 25 forks source link

Update README #3

Closed abaumann closed 6 years ago

abaumann commented 6 years ago

Updated the Dversion flag to not include [square brackets], which does not work correctly.

The [Optional] step for Sirocco is not optional as the dependency is in the pom.xml. If we want this as an optional step, maybe add two different examples?

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
abaumann commented 6 years ago

I signed it!

On Tue, May 22, 2018 at 11:09 AM, googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA Individual signers

Corporate signers

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/dataflow-opinion-analysis/pull/3#issuecomment-391027136, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuGbwS71i1TwD76o-UvkzF_enaloL83ks5t1CpHgaJpZM4UI2Cq .

googlebot commented 6 years ago

CLAs look good, thanks!

datancoffee commented 6 years ago

Fixing docs with correct instructions

abaumann commented 6 years ago

👍 👍