GoogleCloudPlatform / datastore-ndb-python

Client library for use with Google Cloud Datastore from within the Google App Engine Python runtime.
https://cloud.google.com/appengine/docs/standard/python/ndb/
Apache License 2.0
114 stars 48 forks source link

Revert "Revert "Update LICENSE"" #289

Closed tswast closed 6 years ago

tswast commented 6 years ago

Reverts GoogleCloudPlatform/datastore-ndb-python#288

Reopening this, since this is still relevant. One technical reason for the change is you'll notice GitHub does not detect this repository as Apache 2.0.

image

Whereas it does in repositories where the license file is verbatim.

image

The relevant public policy is available at https://opensource.google.com/docs/releasing/preparing/#include-license-file-and-source-code-headers

There must also be a file named LICENSE in the top-level directory that contains a copy of the license. For the Apache License, simply copy the official 2.0 license into your LICENSE file verbatim (do not edit the Copyright bit template in there, only when you paste that template in the header of your source code files.)

If you need additional justification beyond this policy, please discuss offline and not on GitHub.

wsh commented 6 years ago

Again, please do not merge random commits without a member of the Cloud Datastore team (in this case) reviewing the change. That was not justified under the circumstances and is what led to the initial rollback.