GoogleCloudPlatform / datastore-ndb-python

Client library for use with Google Cloud Datastore from within the Google App Engine Python runtime.
https://cloud.google.com/appengine/docs/standard/python/ndb/
Apache License 2.0
114 stars 48 forks source link

Add support for datetime.time and datetime.date to GenericProperty #291

Closed patelnav closed 2 years ago

patelnav commented 6 years ago

Expando explodes if you try to set values that were read from DateProperty or TimeProperty. This change adds support for datetime.date and datetime.time so we no longer hit: Property X does not support <type 'datetime.date'> types

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
googlebot commented 6 years ago

CLAs look good, thanks!

patelnav commented 6 years ago

I signed it!