CloudSQL Import - Replace the need to share the dump file publicly

an0rak-dev commented 5 years ago

Hello,

First, thanks for those samples, it helps me a lot everyday ! 😄

In the Import CloudSQL sample, one of the prerequisites is to publicly share the SQL Dump. I think that this could be a bad practice and leads to security flaws ( https://github.com/GoogleCloudPlatform/deploymentmanager-samples/tree/master/examples/v2/cloudsql_import#prerequsites ).

Maybe, we can change the orchestration of the DM script this way :

Create the Cloud SQL Instance
Create the GCS bucket & add the dump in it (from SourceRepo for example)
Add the CloudSQL service account with role Storage Object Viewer permission to the GCS bucket
Make the actual import

I can do the actual PR if you want so 😃

oussamahammami commented 5 years ago

PR done ;) thanks for the feedback. #468

an0rak-dev commented 5 years ago

Hi @oussamahammami

Thanks for the PR ! :D

GoogleCloudPlatform / deploymentmanager-samples