GoogleCloudPlatform / dialogflow-integrations

Dialogflow integrations with multiple platforms including KIK, Skype, Spark, Twlio, Twitter and Viber
https://cloud.google.com/dialogflow/
Apache License 2.0
256 stars 503 forks source link

Add integration for CM.com SMS and WhatsApp Business #23

Closed joepb closed 4 years ago

joepb commented 4 years ago

This MR will add integration support for CM.com SMS and WhatsApp Business channels

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

joepb commented 4 years ago

@googlebot I signed it!

joepb commented 4 years ago

@googlebot I signed it!

joepb commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

tyhu-google commented 4 years ago

joepb@, thanks for contributing to Dialogflow's repo! Would you mind providing more contexts about this commit? Like what are the use-cases, who is the potential customer? Another thing is, it mentioned it is for Whatsapp business, is that possible this one becomes a more generic solution for any customer to integrate with WhatsApp?

joepb commented 4 years ago

Hi @tyhu-google,

We, CM.com, are a CPaaS provider, connecting businesses to various mobile channels, among SMS and WhatsApp Business and a few others which I left out of scope here, because most are not relevant yet and/or there already exist direct integrations for DialogFlow. We might be adding them in the future if the demand exists.

The use-case for this integration could be for any of our clients to connect their messaging channels via our platform to DialogFlow. We get the question quite often from clients that want to connect to DialogFlow. This addition would help them connect the channels themselves using GCR.

WhatsApp Business (Facebook) does not accept direct connections from customers or businesses. Anyone desiring a WABiz connection, will have to go via one of the authorized WhatsApp Business-partners, of which CM.com is one. So a more generic WA connection is theoretically impossible at this time: it will always be specific to the partner providing the services.

tyhu-google commented 4 years ago

joepb@, thanks for the information. Dialogflow team will review your request and will get back to you shortly.

joepb commented 4 years ago

Hi @tyhu-google Quite some time has passed already without any news... Could you perhaps share a status update? Thanks

joepb commented 4 years ago

If customers are requesting more features and a bug fix, is there a process to report them to your company/team?

That's a good question. I'm not really sure what's common within Google repos to manage these things?

It's always possible to open an issue on our fork: https://github.com/CMTelecom/dialogflow-integrations We have a public support channel available via support@cm.com

How best to communicate that to the end users? Is there are convention for that within Google?

tyhu-google commented 4 years ago

If customers are requesting more features and a bug fix, is there a process to report them to your company/team?

That's a good question. I'm not really sure what's common within Google repos to manage these things?

It's always possible to open an issue on our fork: https://github.com/CMTelecom/dialogflow-integrations We have a public support channel available via support@cm.com

How best to communicate that to the end users? Is there are convention for that within Google?

You may consider add one more section into README like: "Report an issue" and provide an instruction how customer could contact your team about it. What do you think?

googlebot commented 4 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

joepb commented 4 years ago

You may consider add one more section into README like: "Report an issue" and provide an instruction how customer could contact your team about it. What do you think?

Agreed. I have added a chapter "Feedback and Questions" to the top of the readme file, explaining the various support options.