GoogleCloudPlatform / dialogflow-integrations

Dialogflow integrations with multiple platforms including KIK, Skype, Spark, Twlio, Twitter and Viber
https://cloud.google.com/dialogflow/
Apache License 2.0
256 stars 503 forks source link

Fix empty queryParameters.payload in the request sent from Dialogflow to the fulfillment webhook #5

Closed mekpavit closed 4 years ago

mekpavit commented 4 years ago

WHY

Normally, the queryParameters.payload, which is put in projects.agent.sessions.detectIntent, should be shown in the request that is sent from Dialogflow to the fulfillment webhook. The document states that the payload CAN BE BOTH ProtoStruct or JSON objects, but, when the JSON objects was implemented, no payload is received by the webhook. (session.detectIntent)

After searching for the solution, this problem was once mentioned in this StackOverflow question. It seems that converting the queryParameters.payload from JSON objects to Struct solves the issue. So, this pull request is proposed to implement this solution to the dialogflow-integration server.

WHAT

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

mekpavit commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

tyhu-google commented 4 years ago

mekpavit@, thanks for sending your pull requests. Dialogflow team will review and verify it. We will merge the request if it all looks good.