GoogleCloudPlatform / distributed-load-testing-using-kubernetes

Distributed load testing using Kubernetes on Google Container Engine
http://cloud.google.com/solutions/distributed-load-testing-using-kubernetes
Apache License 2.0
442 stars 259 forks source link

remove field 'key' in spec env from locust controller yaml #20

Closed uni-3 closed 2 years ago

uni-3 commented 6 years ago

Since "key" field seems not to be supported, I deleted it from the yaml files. I have confirmed that it worked with kubectl v1.8.0.

Thanks

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


uni-3 commented 6 years ago

I signed it

googlebot commented 6 years ago

CLAs look good, thanks!

faizalkassamalisc commented 6 years ago

I ran into this too. Any reason why this hasn't been merged?