GoogleCloudPlatform / dlp-dataflow-deidentification

Multi Cloud Data Tokenization Solution By Using Dataflow and Cloud DLP
Apache License 2.0
89 stars 53 forks source link

Fix Gradle wrapper, add UT coverage to CI pipeline #166

Closed anurag-paliwal closed 1 year ago

anurag-paliwal commented 1 year ago

Fix Gradle wrapper, add UT coverage to CI pipeline

Description (Describe in detail the fix made) :

Bug ID (if any) : b/303544224

Public Documentation (if any) :

Used codecov.io integration.

TESTED (Test Cases with scenario and description - must have 1 positive and 1 negative scenario) :

No code change and CI Run passes.

saurabhgadia4 commented 1 year ago

Thanks Anurag. Will this plugin bot also output the incremental coverage for individual files changed in the PR - example?

anurag-paliwal commented 1 year ago

Thanks Anurag. Will this plugin bot also output the incremental coverage for individual files changed in the PR - example?

@saurabhgadia4 - it can but github won't really render it that nicely. Honestly for dev experience the IDE will give a much better experience while these checks can be kept on github more as a overall health marker + preventing regressions. Example:

image
saurabhgadia4 commented 1 year ago

Thanks Anurag. Will this plugin bot also output the incremental coverage for individual files changed in the PR - example?

@saurabhgadia4 - it can but github won't really render it that nicely. Honestly for dev experience the IDE will give a much better experience while these checks can be kept on github more as a overall health marker + preventing regressions. Example: image

Sounds good. At the very least we should have the incremental coverage for the file changes introduced by PR.

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9984855). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #166   +/-   ##
=========================================
  Coverage          ?   13.06%           
  Complexity        ?       63           
=========================================
  Files             ?       51           
  Lines             ?     2365           
  Branches          ?      202           
=========================================
  Hits              ?      309           
  Misses            ?     2037           
  Partials          ?       19           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more