search

GoogleCloudPlatform / dlp-dataflow-deidentification

Multi Cloud Data Tokenization Solution By Using Dataflow and Cloud DLP
Apache License 2.0
89 stars 53 forks source link

Enable spotless plugin to run during all builds. #173

Closed anurag-paliwal closed 12 months ago

anurag-paliwal commented 12 months ago

Summary (Short summary of what is being done) :

Enable gradle spotless plugin to format code using google-java-format style.

Description (Describe in detail the fix made) :

This applies spotless check during gradle build. After code modification run ./gradlew :spotlessApply to reformat the code according to Google Java Style. This PR also includes change to format existing code using same. This can also be integrated with IDEs

Bug ID (if any) :


Public Documentation (if any) :

https://github.com/diffplug/spotless/tree/main/plugin-gradle

TESTED (Test Cases with scenario and description - must have 1 positive and 1 negative scenario) :

Tested couple of deid, inspect scenarios locally and tested via CI.

[Ignoring code coverage checks.]

codecov[bot] commented 12 months ago

Codecov Report

Merging #173 (43a6eef) into master (7e3dd13) will decrease coverage by 0.09%. Report is 1 commits behind head on master. The diff coverage is 10.09%.

@@             Coverage Diff              @@
##             master     #173      +/-   ##
============================================
- Coverage     12.45%   12.37%   -0.09%     
  Complexity       63       63              
============================================
  Files            53       53              
  Lines          2480     2521      +41     
  Branches        207      209       +2     
============================================
+ Hits            309      312       +3     
- Misses         2152     2190      +38     
  Partials         19       19
Files Coverage Δ
...swarm/tokenization/DLPTextToBigQueryStreaming.java 0.00% <ø> (ø)
...m/google/swarm/tokenization/common/FileReader.java 0.00% <ø> (ø)
...ava/com/google/swarm/tokenization/common/Util.java 30.82% <100.00%> (+0.24%) :arrow_up:
...ogle/swarm/tokenization/orc/ORCColumnNameDoFn.java 100.00% <100.00%> (ø)
...m/google/swarm/tokenization/orc/ORCFileReader.java 100.00% <100.00%> (ø)
...gle/swarm/tokenization/beam/DLPReidentifyText.java 0.00% <0.00%> (ø)
...warm/tokenization/common/SanitizeFileNameDoFn.java 45.45% <0.00%> (ø)
...le/swarm/tokenization/parquet/RecordFlattener.java 0.00% <0.00%> (ø)
...nization/common/BigQueryDynamicWriteTransform.java 0.00% <0.00%> (ø)
...kenization/common/ExtractColumnNamesTransform.java 0.00% <0.00%> (ø)
... and 17 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more