GoogleCloudPlatform / docker-credential-gcr

A Docker credential helper for GCR users
https://gcr.io
Apache License 2.0
284 stars 91 forks source link

Non $PATH setup #117

Open loeffel-io opened 2 years ago

loeffel-io commented 2 years ago

Hello,

currently gcr aborts with ERROR: 'docker-credential-gcr' must exist on your PATH https://github.com/GoogleCloudPlatform/docker-credential-gcr/blob/6093d30b51d725877bc6971aa6700153c1a364f1/cli/configure-docker.go#L74

With https://github.com/bazelbuild/rules_docker/pull/2115 this will get obsolete for a bazel setup

ShantanuJoshi commented 1 year ago

Any update on this? Attempting to run without making docker-credential-gcr available on PATH

lindsayismith commented 1 year ago

Can I clarify what you're asking for. I think that configure-docker is checking that the tool is on the path, because if it's not, then it can't actually be run as the credential helper.

Are you asking that configure-docker doesn't check this - or that it warns instead of failing?