search

GoogleCloudPlatform / docker-credential-gcr

A Docker credential helper for GCR users
https://gcr.io
Apache License 2.0
289 stars 92 forks source link

compute/metadata: unset ResponseHeaderTimeout #72

Closed lastravex closed 4 years ago

lastravex commented 4 years ago

workload identity in gke credentials roundtrip is longer than 2 seconds when under load - this timeout causes gcr auth to fail frequently.

see upstream commit tagged in version v.0.53.0 https://github.com/googleapis/google-cloud-go/commit/fbf2f5121ef6008eb9b7e5c67aa0c9abfa7ac7fc

lastravex commented 4 years ago

fixed in https://github.com/GoogleCloudPlatform/docker-credential-gcr/pull/76 thank you! @dekkagaijin will there be a maintenance release including this? It is impacting GKE users.

dekkagaijin commented 4 years ago

@AdamMichaelLong I can. I think I'll add in a fix for https://github.com/GoogleCloudPlatform/docker-credential-gcr/issues/69 as well