search

GoogleCloudPlatform / docker-credential-gcr

A Docker credential helper for GCR users
https://gcr.io
Apache License 2.0
292 stars 92 forks source link

Update docker-credential-gcr version in the google cloud sdk install tarball #83

Closed sbocinec closed 4 years ago

sbocinec commented 4 years ago

Even the latest available Cloud SDK version 310.0.0 installs old docker-credential-gcr version 1.5.0 from 2018:

gcloud version |egrep 'SDK|docker'
Google Cloud SDK 310.0.0
docker-credential-gcr 1.5.0

This old docker-credential-gcr version is causing lot of issues, forces users to set CLOUDSK_PYTHON variable to python2 or to remove ~/.docker/config.json.

Is it possible to update the GCR credential helper distributed in the cloud SDK with the latest 2.0.2 version?

I can't find the Google Cloud SDK git repo, so reporting the issue here.

Thanks in advance for fix!

sbocinec commented 4 years ago

Oh, so I later found, updating the credentials helper does not fix the issue. The real culprit is mismatch between cpython version docker-compose was compiled with.

The binary version available from https://docs.docker.com/compose/install/ is built with cpython 3.7, though on distributions with python 3.8 installed by default (e.g. Ubuntu 20.04 LTS), this is causing the https://github.com/GoogleCloudPlatform/github-actions/issues/128 issue.

Removing the binary version, and installing docker-compose using pip, e.g. pip3 install docker-compose or pip install docker-compose fixes the issue:

docker-compose version 1.27.3, build unknown
docker-py version: 4.3.1
CPython version: 3.8.2
OpenSSL version: OpenSSL 1.1.1f  31 Mar 2020

I'm thus closing this issue.