search

GoogleCloudPlatform / dotnet-docs-samples

.NET code samples used on https://cloud.google.com
https://cloud.google.com/dotnet
Apache License 2.0
737 stars 1.19k forks source link

Swagger: Modernize application and update dependencies #1426

Open amanda-tarafa opened 3 years ago

amanda-tarafa commented 3 years ago

This sample code seems to be really outdated. Code changes are needed to bring it up to date. But that just makes sense if this samples is still relevant which I don't have the context to know.

@SurferJeffAtGoogle and @simonz130, you seem to have been the main contributors to this sample in the past. Can you give more context as to whether this sample is still being used or not, etc.?

SurferJeffAtGoogle commented 2 years ago

This sample code seems to be really outdated.

Which code?

amanda-tarafa commented 2 years ago

This one here: https://github.com/GoogleCloudPlatform/dotnet-docs-samples/tree/main/endpoints/getting-started

SurferJeffAtGoogle commented 2 years ago

I don't think so. I recommend removing the sample.

amanda-tarafa commented 2 years ago

Hmmm, the code is actually being used here: https://cloud.google.com/endpoints/docs/openapi/get-started-app-engine-dotnet The link is both offered as the sample to download and there are a few snippets from the yaml file included in the doc.

I'll try to find an owner for this.

amanda-tarafa commented 2 years ago

@iennae when you are ready for this, do loop me in and I can help with the .NET bits. Thanks.