search

GoogleCloudPlatform / elcarro-oracle-operator

El Carro is a new project that offers a way to run Oracle databases in Kubernetes as a portable, open source, community driven, no vendor lock-in container orchestration system. El Carro provides a powerful declarative API for comprehensive and consistent configuration and deployment as well as for real-time operations and monitoring.
Apache License 2.0
209 stars 55 forks source link

Ensure monitoring pod is removed with instance #282

Closed kurt-google closed 1 year ago

kurt-google commented 1 year ago

Previously we were relying on owner's references for cleanup but these do not actually ensure any cleanup is done when the owner is destroyed. Instead we need to take action to delete these deployments during the instance deletion steps similar to databases.

bug: 259996978 Change-Id: I47be39b7faf5fe4ce106ddd1f0ee8cb74fd6ec4b

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akinfermo, kurt-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/elcarro-oracle-operator/blob/main/OWNERS)~~ [akinfermo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment