search

GoogleCloudPlatform / elcarro-oracle-operator

El Carro is a new project that offers a way to run Oracle databases in Kubernetes as a portable, open source, community driven, no vendor lock-in container orchestration system. El Carro provides a powerful declarative API for comprehensive and consistent configuration and deployment as well as for real-time operations and monitoring.
Apache License 2.0
209 stars 55 forks source link

Updated image-type from cos to cos_containerd for GKE version >1.23 #310

Closed nasmart closed 1 year ago

nasmart commented 1 year ago

As detailed in About the Docker node image deprecation support for the Docker runtime has been removed from GKE from version 1.23 (1.24 for upgrades) and "image-type" should be changed from "cos" to "cos_containerd". See Docker and containerd node images.

google-oss-prow[bot] commented 1 year ago

Hi @nasmart. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
akinfermo commented 1 year ago

/ok-to-test

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akinfermo, kurt-google, nasmart

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/elcarro-oracle-operator/blob/main/OWNERS)~~ [akinfermo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment