GoogleCloudPlatform / emblem

Archived: Emblem Giving is a sample application that demonstrates a serverless architecture with continuous delivery, and trouble recovery. :diamond_shape_with_a_dot_inside:
Apache License 2.0
239 stars 61 forks source link

Update setup.sh to update breaking change introduced in `hashicorp/terraform-provider-google` v5 #1012

Closed pattishin closed 10 months ago

pattishin commented 10 months ago

Problem

Investigated with @jping0220. During setup script execution, seeing errors pop up for google_secret_manager_secret.

Screenshot 2023-12-01 at 11 51 32 AM

What we're using is out of date per https://github.com/hashicorp/terraform-provider-google/commit/6f7206de79b44f862f602d29b1a24653f379d019

This script needs to be updated like so:

Screenshot 2023-12-01 at 12 06 02 PM

(ref: https://github.com/hashicorp/terraform-provider-google/blob/f5fd69561aae2efd7d0ad886b765bc258987f089/website/docs/guides/version_5_upgrade.html.markdown#resource-google_secret_manager_secret)

Steps to Reproduce

Simply execute:

sh setup.sh

Expected behavior

Expected for the setup script to provision our GCPs smoothly without errors.

pattishin commented 10 months ago

Closing out as this was completed #1013