Closed loosebazooka closed 7 years ago
I messed up and squashed and merged, for this to work, I think we need to do it as two PRs
no biggie. The commit exists on your release branch anyway.
On Wed, May 17, 2017 at 11:03 AM, Appu Goundan notifications@github.com wrote:
I messed up and squashed and merged, for this to work, I think we need to do it as two PRs
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/endpoints-framework-maven-plugin/pull/26#issuecomment-302119524, or mute the thread https://github.com/notifications/unsubscribe-auth/AHf5HSj73ddYNTjt4bduPQnNJVvPFv0Oks5r6wxZgaJpZM4NdB4y .
The first commit will be tagged and released. This is a departure from our previous release commit strategy (tagging on another branch). It's how cloud-intellij does releases and I think I like this one more.