search

GoogleCloudPlatform / endpoints-framework-maven-plugin

Apache License 2.0
5 stars 13 forks source link

Expose info.version as a param that can be passed in through the POM #57

Closed quentin-sensome closed 2 years ago

quentin-sensome commented 6 years ago

Hi,

It would be nice to be able to configure the version of the OpenAPI specifications via the pom.xml file. Something like this:

<plugin>
  <groupId>com.google.cloud.tools</groupId>
  <artifactId>endpoints-framework-maven-plugin</artifactId>
  <version>2.0.0</version>
  <configuration>
    <basePath>/_ah/api</basePath>
    <hostname>myapp.appspot.com</hostname>
    <info.version>1.0.0</info.version>
  </configuration>
</plugin>

As of now, it makes it quite difficult to use the plugin with configuration management tools, and forces to intervene manually in deployment pipelines to increment versions. Having the possibility to configure this would smoothen the process a lot.

patflynn commented 6 years ago

@tangiel is this a parameter to the endpoints tool?

tangiel commented 6 years ago

Not at the moment.

patflynn commented 6 years ago

So this would have to be a FR against the tool first?

On Tue, Jul 31, 2018 at 4:21 PM Daniel T notifications@github.com wrote:

Not at the moment.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/endpoints-framework-maven-plugin/issues/57#issuecomment-409354725, or mute the thread https://github.com/notifications/unsubscribe-auth/AHf5Hdi0ysPlPlzqFnzY0HIHcwF8np5uks5uMLwzgaJpZM4VouA4 .

tangiel commented 6 years ago

Yep.

patflynn commented 6 years ago

@quentin-sensome you may want to follow https://github.com/cloudendpoints/endpoints-java/issues/156 to see if this gets prioritized.

JoeWang1127 commented 2 years ago

close as not planned