search

GoogleCloudPlatform / endpoints-proto-datastore

Apache License 2.0
154 stars 52 forks source link

Ordering args according to the _message_field_schema #137

Closed elielhaouzi closed 8 years ago

elielhaouzi commented 8 years ago

It can be a solution to #135 problem. What I am doing is simply ordering the alias_args according to the _message_fields_schema. In case of ancestor path you just set the fields in the correct order in _message_fields_schema.

dhermes commented 8 years ago

I don't think this is necessary. Users can handle removing duplicates on their own.

elielhaouzi commented 8 years ago

The purpose is not for removing duplicates but for ordering the CombinedContainer fields according to the _message_fields_schema. It will resolve all the issues according to ancestor path.

dhermes commented 8 years ago

Right. I'm just not sure it's necessary.

elielhaouzi commented 8 years ago

OK thanks danny :)

dhermes commented 8 years ago

Sure thing. Sorry.