search

GoogleCloudPlatform / endpoints-samples

Apache License 2.0
89 stars 60 forks source link

Use long flag names #39

Closed navinger closed 7 years ago

navinger commented 7 years ago

For readability, let's use the long flag names for the ESP options (https://cloud.google.com/endpoints/docs/openapi/specify-proxy-startup-options).

Note there's a comma after "SERVICE_CONFIG_ID". That doesn't look right to me, but I didn't want to change it without checking with somebody.

navinger commented 7 years ago

Clicked Create Pull Request twice by mistake. I do want the long flag names for the ESP options.

kryzthov commented 7 years ago

The trailing comma is fine (in YAML), you can keep it or remove it. Can you reopen this pull request, or create a new one?

navinger commented 7 years ago

Closed the pull request by mistake.

kryzthov commented 7 years ago

LGTM!