search

GoogleCloudPlatform / endpoints-samples

Apache License 2.0
89 stars 60 forks source link

Modify all the languages of GKE deployment to use Ingress LB and service in order to setup container native LB. #68

Closed shuoyang2016 closed 3 years ago

shuoyang2016 commented 3 years ago

Modify all the languages of GKE deployment to use Ingress LB and service in order to setup container native LB.

This change may need to be submitted after we update the public doc to start an IP alias enabled cluster. There are some internal changes inside Google doc:

The internal change is we'll update the GCP tutorial openapi/get-started-kubernetes-espv2 by

shuoyang2016 commented 3 years ago

@nareddyt @TAOXUY @qiwzhang PTAL. I cannot add reviewers. Not sure why :)

nareddyt commented 3 years ago

@qiwzhang please add @shuoyang2016 to https://github.com/orgs/GoogleCloudPlatform/teams/esp-dev

nareddyt commented 3 years ago

There are some internal changes which I am not sure if we want to add them here?

Can you explain the internal changes?

shuoyang2016 commented 3 years ago

Thanks Teju.

Can you quickly summarize which tutorials use this file? Unfortunately our code samples are broken up across multiple repos, so I can't tell where these are used.

These codes are used by https://cloud.google.com/endpoints/docs/openapi/get-started-kubernetes-engine-espv2. I did a internal search and it looks this is the only place. Indeed it's not easy to find out which samples are used by which doc :(

Specifically, please make sure they won't break the raw k8s (not GKE) tutorial.

Yeah, double checked the openapi/gRPC k8s doc uses different samples.

Can you explain the internal changes?

The internal change is we'll update the GCP tutorial openapi/get-started-kubernetes-espv2 by

I updated the PR description too.

nareddyt commented 3 years ago

Ack, sounds good. Let make a CL for the internal changes and we can submit the CL and PR together.