search

GoogleCloudPlatform / esp-v2

A service proxy that provides API management capabilities using Google Service Infrastructure.
https://cloud.google.com/endpoints/
Apache License 2.0
272 stars 170 forks source link

Update googleapi version to latest #884

Closed siqidong closed 8 months ago

siqidong commented 8 months ago

Update googleapi version to include the newly added field api_key_uid in https://github.com/googleapis/googleapis/blob/cff4df02d7f68e7d131357815a4faf2d26b87957/google/api/servicecontrol/v1/service_controller.proto#L128

google-oss-prow[bot] commented 8 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

siqidong commented 8 months ago

/test all

google-oss-prow[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: siqidong, TAOXUY

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/esp-v2/blob/master/OWNERS)~~ [TAOXUY] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
TAOXUY commented 8 months ago

Maybe you could include your report change in the same PR.

siqidong commented 8 months ago

/retest-required

siqidong commented 8 months ago

/retest-required

google-oss-prow[bot] commented 8 months ago

New changes are detected. LGTM label has been removed.

siqidong commented 8 months ago

/retest-required

google-oss-prow[bot] commented 8 months ago

@siqidong: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ESPv2-presubmit-asan 0394da216d18ad5f4dbb33c5d69121ab0720053a link true /test ESPv2-presubmit-asan
ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore 0394da216d18ad5f4dbb33c5d69121ab0720053a link true /test ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore
ESPv2-cloud-run-e2e-app-engine-http-bookstore 0394da216d18ad5f4dbb33c5d69121ab0720053a link true /test ESPv2-cloud-run-e2e-app-engine-http-bookstore
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
siqidong commented 8 months ago

Maybe you could include your report change in the same PR.

Thanks Jason! Will do it next time for ESP.