Enable deterministic Go Protobuf marshaling (encoding)

GoogleCloudPlatform / esp-v2

A service proxy that provides API management capabilities using Google Service Infrastructure.

https://cloud.google.com/endpoints/

Apache License 2.0

272 stars 170 forks source link

Enable deterministic Go Protobuf marshaling (encoding) #889

Open stapelberg opened 7 months ago

stapelberg commented 7 months ago

While developing Go Protobuf, we found this line to be responsible for a test failure when enabling fully lazy extensions (Google-internal bug reference: b/328746084).

Your test seems to compare Protobuf-encoded data. As explained on go/go-proto-stability, you should not rely on the Protobuf wire encoding being stable across different versions of your program.

go/go-proto-stability lists a couple of strategies you could pursue for a more reliable test, but for now, to unblock our optimization, enabling deterministic marshaling side-steps many vectors for change.

google-oss-prow[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stapelberg Once this PR has been reviewed and has the lgtm label, please assign shuoyang2016 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/esp-v2/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

google-oss-prow[bot] commented 7 months ago

Hi @stapelberg. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

dchakarwarti commented 7 months ago

cc: @shuoyang2016